Page 1 of 2

Mighty Strikes and WeaponSkill

Posted: Mon Mar 18, 2019 11:39 pm
by makise
I'm only around lvl 40 on war, but I feels like Mighty Strikes doesn't work on Weaponskill on Eden, Am I wrong? Are there any test server player can access to test those kind of stuff?


Not sure if I'm posting in the correct forum, so sorry if it's not the propper place to post this

Re: Mighty Strikes and WeaponSkill

Posted: Tue Mar 19, 2019 1:54 pm
by Veikuri
Go out to a zone and use Iron Break, then use SA Iron Break as war/thf, then use Mighty Strikes + Iron Break. Check the TP return to make sure you don't Double Attack on a lv 1 mob. SA + Iron Break and Mighty Strikes + Iron Break should do the same, and Iron Break by itself should do less. If Mighty Strikes + Iron Break does the same as SA, then it works, if it does the same as regular then it doesn't work.

Re: Mighty Strikes and WeaponSkill

Posted: Fri Mar 22, 2019 1:56 pm
by makise
It is still not working, but it should be being worked on as a bug about it has been reported

Re: Mighty Strikes and WeaponSkill

Posted: Sun Apr 21, 2019 9:01 pm
by Caelic
Mighty strikes is not supposed to work on weapon skills.

Re: Mighty Strikes and WeaponSkill

Posted: Mon Apr 22, 2019 12:18 am
by Aneyus
Caelic wrote:
Sun Apr 21, 2019 9:01 pm
Mighty strikes is not supposed to work on weapon skills.
It absolutely does work with weapon skills on retail, and it always has. A quick wiki search confirms this as well.

"Also affects physical weapon skills used while ability is active."
https://ffxiclopedia.fandom.com/wiki/Mighty_Strikes

Re: Mighty Strikes and WeaponSkill

Posted: Tue Apr 23, 2019 3:10 pm
by Istanbul
Aneyus wrote:
Mon Apr 22, 2019 12:18 am
Caelic wrote:
Sun Apr 21, 2019 9:01 pm
Mighty strikes is not supposed to work on weapon skills.
It absolutely does work with weapon skills on retail, and it always has. A quick wiki search confirms this as well.

"Also affects physical weapon skills used while ability is active."
https://ffxiclopedia.fandom.com/wiki/Mighty_Strikes
Yep, as a career warrior on fenrir, mighty strikes + top ws was a go to for a big spike of damage.

Re: Mighty Strikes and WeaponSkill

Posted: Tue Apr 23, 2019 8:11 pm
by Caelic
Veikuri wrote:
Tue Mar 19, 2019 1:54 pm
Go out to a zone and use Iron Break, then use SA Iron Break as war/thf, then use Mighty Strikes + Iron Break. Check the TP return to make sure you don't Double Attack on a lv 1 mob. SA + Iron Break and Mighty Strikes + Iron Break should do the same, and Iron Break by itself should do less. If Mighty Strikes + Iron Break does the same as SA, then it works, if it does the same as regular then it doesn't work.
Mighty Strikes testing will not work on level 1 mobs. Critical strikes increase your pdif and your pdif is already capped if fighting something with far less defense than your attack.

I take back my last statement, I didn't know Mighty Strikes was supposed to work with weapon skills. Being on DSP for far too long has started to warp my views.

I did just a quick test on a test server as a level 24 against EP dhalmels so that I knew my pdif wasn't going to cap out and...

Image

So something's not right. This is on my owns server so Eden may have something different coded but I seriously doubt it. There's a check case in the script for weapon skills in weaponskills.lua and it seems to be increasing the pdif if the player has Mighty Strikes active but... it's not really? Something's bugged.

Edit: the check for Mighty Strikes is on the same line for Sneak Attack and we know SA works so... I checked if maybe the check for the player having Mighty Strikes was just broken somehow so I wrote a quick debug message if it's working and...

Image

So idk.

Edit 2: Found the issue. In weaponskills.lua:

Code: Select all

if (params.canCrit or isSneakValid or isAssassinValid) then
change to:

Code: Select all

if (params.canCrit or isSneakValid or isAssassinValid or hasMightyStrikes) then
The Mighty Strikes check was in fact in the script, it was just inside that if statement but was never able to actually activate because most weaponskills are set to FALSE under their params.canCrit. Interesting tidbit because of this: Raging Rush has params.canCrit = TRUE so at least that works correctly right now as-is on Eden w/ MS. Will have a cool pic of this working on Fast Blade post-fix in a minute.

Edit 3: Woohoo~
Image

Re: Mighty Strikes and WeaponSkill

Posted: Wed Apr 24, 2019 1:28 pm
by Istanbul
Wow, good work! Thanks for the effort!

Re: Mighty Strikes and WeaponSkill

Posted: Fri May 10, 2019 6:06 pm
by altnob
Mighty strikes only crits on weapons skills that say "chance to crit varies with tp" It was like that in retail.

Re: Mighty Strikes and WeaponSkill

Posted: Sun May 19, 2019 1:39 am
by makise
Hmmm no, always worked with every ws.

-> https://ffxiclopedia.fandom.com/wiki/Mi ... did=262274